Allow repo's to set DefaultPathTokenToIgnore property#5075
Merged
shahabhijeet merged 1 commit intoAzure:LTSBuildToolsfrom Dec 11, 2018
Merged
Conversation
This allows repos to set the set of path tokens to ignore in their repo's directory.build.props file and we pick it up.
weshaggard
commented
Dec 11, 2018
| <AssemblyOriginatorKeyFile>$(LibraryToolsFolder)\MSSharedLibKey.snk</AssemblyOriginatorKeyFile> | ||
| <NoWarn>1591;1701;1573;CS1591</NoWarn> | ||
| <DefaultPathTokenToIgnore>$(IgnorePathTokens) Microsoft.Azure.KeyVault.Samples</DefaultPathTokenToIgnore> | ||
| <DefaultPathTokenToIgnore>$(DefaultPathTokenToIgnore) $(IgnorePathTokens)</DefaultPathTokenToIgnore> |
Member
Author
There was a problem hiding this comment.
@shahabhijeet I removed Microsoft.Azure.KeyVault.Samples from this list because I believe you told me it is no longer needed if that isn't the case or I misunderstood I can keep it here.
shahabhijeet
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @shahabhijeet